Repository navigation
merge queue: checking #1701 on main (af10ef0) - #1742
Closed
mergify[bot] wants to merge 11 commits into
Closed
mergify[bot] wants to merge 11 commits into
mergify[bot] wants to merge 11 commits into
Conversation
The brief's test name has a comma, which the commit-msg hook rejects in a Test-First trailer; the test reads 'and is hidden' instead. Test-First: src/design/icons/icon.test.tsx::every registered icon renders a 20 px svg and is hidden unless labelled Test-First: src/design/icons/icon.test.tsx::an empty label stays hidden Test-First: src/design/icons/icon.test.tsx::has an equivalent for every classic glyph and every route glyph Test-First: src/design/icons/icons.notice.test.ts::THIRD_PARTY_NOTICES lists Lucide and the licence file exists Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Icon renders 24 Lucide paths copied as data (ISC and Feather MIT notice shipped as LUCIDE-LIZENZ.txt), with stand-ins for the classic, route and Select glyphs. No caller migrates; the classic Icon stays until KR-15. Test-First: src/design/icons/icon.test.tsx::every registered icon renders a 20 px svg and is hidden unless labelled Test-First: src/design/icons/icon.test.tsx::an empty label stays hidden Test-First: src/design/icons/icon.test.tsx::has an equivalent for every classic glyph and every route glyph Test-First: src/design/icons/icons.notice.test.ts::THIRD_PARTY_NOTICES lists Lucide and the licence file exists Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: plan text only Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: merge of main, conflict resolution only Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ns page (R1701-ROOT1, R1701-F1) No-Test: adds coverage for existing behaviour (review R1701-F1) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t (R1701-L1) Test-First: src/design/icons/icons.notice.test.ts::a Vite build ships the glyph paths together with both copyright notices Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…s a legal comment (R1701-L1) Regression-For: 77c3cfb Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
# Conflicts: # docs/PLAN.md
… runs on Windows (R1701-T1)
execFileSync("npx") without a shell cannot start the npx.cmd wrapper on
Windows. Run process.execPath with node_modules/vite/bin/vite.js instead.
Regression-For: 77c3cfb
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: merge commit, docs/PLAN.md conflict only Co-Authored-By: GPT-6 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch innocent-estragon-30lxsw of the
defaultqueue, to test #1701 before it merges intomain. Pushing to this branch or closing this pull request removes #1701 from the queue.What this draft tests
Mergify checks that #1701 still passes CI on top of
main. CI runs on this draft's code, built in this order:mainataf10ef0🎉 Where it stands: checks passed
CI passed on this draft.
Follow the
defaultqueue in the dashboardWhat happens next
mainand closes this draft.Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
defaultfor mergecheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergemain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge ProtectionsRequired conditions to stay in the queue
-conflict-draftbase = maincheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergelabel = review-okmain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge Protections